This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 0/3] Updated patches for /proc/<pid>/environ


On Jan 10 16:02, Erik Bray wrote:
> From: "Erik M. Bray" <erik.bray@lri.fr>
> 
> Updated versions of the patch set originally submitted at
> https://cygwin.com/ml/cygwin-patches/2017-q1/msg00000.html
> 
> I think all the indentation/whitespace/braces are cleaned up and consistent.
> 
> I've also made sure that /proc/self/environ works now.
> 
> All new code in these patches is licensed under the 2-clause BSD:
> [...]

You don't have to repeat that for any later patch you'd like to propose,
I added you to the CONTRIBUTORS file now.  Thank you!

> ===============================================================================
> 
> Erik M. Bray (3):
>   Move the core environment parsing of environ_init into a new
>     win32env_to_cygenv function.
>   Add a _pinfo.environ() method analogous to _pinfo.cmdline(), and
>     others.
>   Add a /proc/<pid>/environ proc file handler, analogous to
>     /proc/<pid>/cmdline.
> 
>  winsup/cygwin/environ.cc          | 84 +++++++++++++++++++++++----------------
>  winsup/cygwin/environ.h           |  2 +
>  winsup/cygwin/fhandler_process.cc | 22 ++++++++++
>  winsup/cygwin/pinfo.cc            | 83 +++++++++++++++++++++++++++++++++++++-
>  winsup/cygwin/pinfo.h             |  4 +-
>  5 files changed, 157 insertions(+), 38 deletions(-)

Patchset applied.  The formatting in pinfo.cc was still not entirely
correct, but I tweaked it manually.  Please have a look into commit
171046d.


Thanks a lot!
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

Attachment: signature.asc
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]