Re: [PATCH] RE: Ghost cursors (was: RE: alt-tab: client window receiv es tab / pressing both...)

[Jehan <jehan_something at hotmail dot com>]

Stuart Adamson wrote:
> The magic command line argument is -hidewindowspointerwheninactive.
> Somebody might
> be able to come up with a slightly nicer name ;)  
What about "-noghostcursor" ? That's not very self-explanatory but if 
the man page and the help parameter give enough explanation, it may work.

Or what about "-iwanttoseenodeadcursor"? It's slightly shorter ;)



> In InitOutput.c I've initialized the ScreenInfo member for it to false as
> fFullScreen
> is also initialized to false - however I don't think either of these are
> needed as
> ZeroMemory() is called on the structure which should do this for us.
> Was this an oversight when adding fFullScreen or is it like this to aid
> readability?
To me, it's always better to have explicit initialization, it makes 
thing clearer to see. ZeroMemory is good either for time critical 
sections (and initialization isn't) or for those who forget to 
initialize their variable but it's quite obfuscating. If one wants to 
know where a variable is initialized, he will look for the variable 
name. With ZeroMem, he won't find anything. Moreover, if he want to 
change the default value of some thing (let say 
fHideWindowsPointerWhenInactive ;)), he won't have to search for the 
place where to put the code (even if in our case it's obvious).
And since Harold (and any good programmer I think) wants to make to code 
easy to ready, I thinks explicit initialization is the best. And if one 
of the two way should go away, I vote for removing ZeroMem. :)

	Jehan