This is the mail archive of the cygwin-xfree@cygwin.com mailing list for the Cygwin XFree86 project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

AW: AW: cygwin.rules - Enabling shared libXt finally?


No,

there is no functional changes. I only want to make sure, that no c function
in Intrinsic.c can use the symbol _y (in c 'y'),
so this patch renames it to __$XtInherit, which isn't usable for c
functions.

BTW: I was very in rush while doing the last patch, which may fails to be
applied. The symbol which has to be patched is _y and not _$$y like done in
the previous patch. I've added an updated patch.

Ralf

--- Initialize-old.c       2003-10-21 20:21:18.000000000 +0200
+++ Initialize.c   2003-10-21 20:23:25.000000000 +0200
@@ -236,8 +236,8 @@

 asm (".data\n\
  .globl __XtInherit        \n\
- __XtInherit:      jmp *_y \n\
-  _y: .long ___XtInherit   \n\
+ __XtInherit:      jmp *__$XtInherit \n\
+ __$XtInherit: .long ___XtInherit   \n\
     .text                 \n");

 #define _XtInherit __XtInherit


Ralf

>
> Errm, this isn't going to change the public interface is it?  That is,
> if Harold releases another libXt with this change, would that break the
> recently re-compiled and released lesstif, etc etc?
>
> --
> Chuck
>
> Ralf Habacker wrote:
>
> >>Not sure I understand.  What should be changed in the current
> version of
> >>the Xt code?
> >
> >
> > only note 1, chaning the label. The second note is only for
> completeness.
> >
> >
> >
> >>Attached are my curent xc/lib/Xt/[Initialize.c|IntrinsicP.h] files.
> >>Please send a diff against these if anything should be changed.  Note
> >>that these are intentionally from the 4.3 branch.
> >>
> >
> > --- Initialize-old.c       2003-10-21 20:21:18.000000000 +0200
> > +++ Initialize.c   2003-10-21 20:23:25.000000000 +0200
> > @@ -236,8 +236,8 @@
> >
> >  asm (".data\n\
> >   .globl __XtInherit        \n\
> > - __XtInherit:      jmp *_$$y \n\
> > -  _$$y: .long ___XtInherit   \n\
> > + __XtInherit:      jmp *__$XtInherit \n\
> > + __$XtInherit: .long ___XtInherit   \n\
> >      .text                 \n");
> >
> >  #define _XtInherit __XtInherit
>
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]