This is the mail archive of the
cygwin-xfree@cygwin.com
mailing list for the Cygwin XFree86 project.
Re: Minimising window with "Always on top" attribute leaves contentsin underlying window
- From: Harold L Hunt II <huntharo at msu dot edu>
- To: cygx <cygwin-xfree at cygwin dot com>
- Date: Sun, 25 Jan 2004 23:37:06 -0500
- Subject: Re: Minimising window with "Always on top" attribute leaves contentsin underlying window
- Reply-to: cygwin-xfree at cygwin dot com
Earle,
Any reason for the following in your patch:
@@ -893,7 +909,7 @@
if (s_pScreenPriv != NULL)
s_pScreenPriv->fWindowOrderChanged = TRUE;
}
- return 0;
+ break;
The thing that strikes me as odd is that you have to return from the
WM_WINDOWPOSCHANGED message without calling DefWindowProc (which will
get called if you change that return to a break) in order to prevent
Windows from breaking that message down into a WM_SIZE and WM_MOVE
message and sending those in addition. My worry is that you may have
essentially found a bug in the WM_WINDOWPOSCHANGED handling that was
fixed by allowing the WM_SIZE and WM_MOVE messages to be generated and
handled, when we should really fix such a bug instead of accidentally
masking its existance.
I'm not comfortable removing this change from your patch since it will
then need to be tested again to verify that things work as expected.
Since you have already been testing it, I figured it would be easier for
you to do the testing :)
Let me know what to do with your patch,
Harold