This is the mail archive of the cygwin-xfree mailing list for the Cygwin XFree86 project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: GetDC(NULL), GetModuleHandle(NULL), etc.

Alexander Gottwald wrote:
On Fri, 2 Sep 2005, Joe Krahn wrote:


GetModuleHandle(NULL) is also in several places. Maybe it's OK, but why not use the hInstance global?


Global variables are bad(TM). With GetModuleHandle(NULL) there is no need
to maintain a global hInstance. The other reason is there is no WinMain
which has the hInstance parameter. So you'd require to set the global
hInstance somewhere else and you have to make sure this occurs before the first reference to hInstance. GetModuleHandle(NULL) was used explicitly
to reduce complexity.

bye
Globals are not really bad(TM), for things that really are global.

But, a redundant global is definitely bad, so the global hInstance should be removed instead.

Joe

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://x.cygwin.com/docs/
FAQ:                   http://x.cygwin.com/docs/faq/

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]