This is the mail archive of the
mailing list for the Cygwin project.
Processor time bug in fhandler_proc.cc
- From: Emil Briggs <emil at baymountain dot com>
- To: cygwin at cygwin dot com
- Date: Thu, 29 Aug 2002 17:56:37 -0400
- Subject: Processor time bug in fhandler_proc.cc
- Organization: Baymountain, Inc.
- Reply-to: emil at baymountain dot com
I think there is a bug in fhandler_proc.cc in the way the results of
NTSTATUS ret = NtQuerySystemInformation (SystemProcessorTimes, (PVOID) &spt,
sizeof spt, NULL);
are handled. Specifically the value of spt.IdleTime.QuadPart is already
included in spt.KernelTime.QuadPart but the code to compute the uptime
doesn't take that into account and adds in the idle time again as shown below.
uptime = (spt.InterruptTime.QuadPart + spt.KernelTime.QuadPart +
spt.IdleTime.QuadPart + spt.UserTime.QuadPart +
spt.DpcTime.QuadPart) / 100000ULL;
Because the Idle time is already included in the KernelTime the computed
uptime is always too large. In the case of a lightly loaded system it's
about a factor of two and is easy to verify by just letting the system sit
for a while and then checking the reported value from /proc/uptime against
wall clock time.
This also affects /proc/stat entry for CPU usage where you can see that
the system value is always larger than the idle value.
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Bug reporting: http://cygwin.com/bugs.html