This is the mail archive of the
cygwin
mailing list for the Cygwin project.
Re: Patch for run-1.3.0-1 core dump
- From: Jon TURNEY <jon dot turney at dronecode dot org dot uk>
- To: cygwin at cygwin dot com
- Date: Mon, 17 Feb 2014 17:25:24 +0000
- Subject: Re: Patch for run-1.3.0-1 core dump
- Authentication-results: sourceware.org; auth=none
- References: <CAOJ7xCsuuhNmtz_ybGJoEeUAdWhJ1Y3+9d5mBtATH-F=VpkYGg at mail dot gmail dot com> <5208EF91 dot 7070504 at cwilson dot fastmail dot fm>
On 12/08/2013 15:22, Charles Wilson wrote:
> On 8/10/2013 1:34 PM, foo wrote:
>> Whenever I execute run.exe, it generates run.exe.stackdump.
>>
>> At line 370 in run.c, run2_freeargv() tries to free newargv, and
>> run2_freeqrgv() expects that newargv is terminated by NULL. However,
>> in shifting newargv at line 253-256, it fails to shift NULL
>> terminator. Therefore, run2_freeargv() frees memory illegally.
>> The following patch is a workaround.
>>
>> --- run.c.old
>> +++ run.c.new
>> @@ -252,7 +252,7 @@
>> newargv = run2_dupargv (argv);
>> /* discard newargv[0] and shift up */
>> free (newargv[0]);
>> - for (newargc = 1; newargc < argc; newargc++)
>> + for (newargc = 1; newargv[newargc-1] != NULL; newargc++)
>> newargv[newargc-1] = newargv[newargc];
>> newargc = argc - 1;
>
> Thanks for the bug report and the patch. I'll investigate and update the
> package soon.
Since I've been running with CYGWIN error_start always set at the moment, I've
noticed that run is always crashing after launching the process.
I went to all the trouble of investigating this, discovering that
run2_freeargv() is double-freeing the last element in newargv because the NULL
terminator isn't moved when the arguments are shifted down over newargv[0],
and writing a patch, before I noticed that we already had one :-(
--- origsrc/run-1.3.0/src/run.c 2013-07-24 16:26:39.000000000 +0100
+++ src/run-1.3.0/src/run.c 2014-02-17 17:08:49.125000000 +0000
@@ -254,6 +254,7 @@ realMain(int argc, char* argv[])
free (newargv[0]);
for (newargc = 1; newargc < argc; newargc++)
newargv[newargc-1] = newargv[newargc];
+ newargv[argc-1] = 0;
newargc = argc - 1;
/* update execname */
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple