This is the mail archive of the
ecos-devel@sourceware.org
mailing list for the eCos project.
Re: contributing filesystem and a failsafe update meachanism for FIS from within ecos applications
- From: Andrew Lunn <andrew at lunn dot ch>
- To: "Neundorf, Alexander" <Alexander dot Neundorf at jenoptik dot com>
- Cc: ecos-devel at ecos dot sourceware dot org
- Date: Thu, 6 Oct 2005 09:21:56 +0200
- Subject: Re: contributing filesystem and a failsafe update meachanism for FIS from within ecos applications
- References: <5A8A17126B73AC4C83968F6C4505E3C502CAD202@JO-EX01.JENOPTIK.NET>
On Thu, Oct 06, 2005 at 08:44:58AM +0200, Neundorf, Alexander wrote:
>
>
> > Von: ecos-devel-owner@ecos.sourceware.org
> >
> > Hi,
> >
> > it's not even one year ago, and already I have the next
> > version of my patch available ;-)
> >
> > The attached patch implements a read-only filesystem for FIS,
> > and three extra utility functions for manipulating it safely
> > from ecos applications.
>
> Any comments ?
The same onces as last year.
You should also take a look at locking. You have some locking between
the FS and the functions, but it has race conditions. The locking the
other way does not exist at all.
You also incorrectly use st_mode, but that is minor.
Andrew