This is the mail archive of the ecos-discuss@sourceware.cygnus.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: small bug in aeb_serial driver


Dave Airlie wrote:
> 
> Hi,
>         I spotted a bug in 1.2.1 arm AEB serial driver that is still in
> CVS... the patch below fixes it... the isr symbol is a #define in
> serial.h, so like is done for lsr earlier in the file I've put the _
> before the real one...
> 
> all small letter #defines are not nice things
> 
> this bug doesn't break anything but it does confuse things  when reading
> the code..

Thanks for the patch, if you don't mind I think I will fix the real problem
instead - the lower-case #defines in aeb_serial.h.

I'd be grateful if someone else could submit a patch for the other drivers
in a similar way (see anon CVS).

Jifl
-- 
Red Hat, 35 Cambridge Place, Cambridge, UK. CB2 1NS  Tel: +44 (1223) 728762
"Plan to be spontaneous tomorrow."  ||  These opinions are all my own fault

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]