This is the mail archive of the
ecos-discuss@sources.redhat.com
mailing list for the eCos project.
ecos 1.3.1
- To: ecos <ecos-discuss at sourceware dot cygnus dot com>
- Subject: [ECOS] ecos 1.3.1
- From: Rafael Rodríguez Velilla <rrv at tid dot es>
- Date: Mon, 28 May 2001 17:47:38 +0200
- Organization: Telefónica I+D
In the implementation of MLQUEUE scheduler I've found that the method
rem_thread doesn't check if the thread that is being removed is the
"current_thread". Shouldn't this check be done in order to raise
"need_reschedule" when that happens?
In the BITMAP scheme it is done.
Another little thing, in the method add_thread I find the following
code:
if (thread->queue != NULL)
{
thread->queue->remove(thread);
thread->queue=NULL;
}
Isn't it true that when remove is invoqued, the member queue of the
thread used as a parameter finishes pointing to NULL? So thread->queue
is innecessary.
TIA
--
Rafael Rodríguez Velilla rrv@tid.es
Telefónica I+D http://www.tid.es
Telf: +34 - 91 337 4270