This is the mail archive of the ecos-discuss@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Bug (I think) in ethernet driver for XScale 80310


On Tuesday 25 September 2001 02:06 pm, Mark Salter wrote:
> >>>>> Jonathan Larmour writes:
> >
> > This is a multi-part message in MIME format.
> > --------------FF3BEAC72F709DCE852EE3DD
> > Content-Type: text/plain; charset=us-ascii
> > Content-Transfer-Encoding: 7bit
> >
> > Richard Wicks wrote:
> >> The file
> >> ${ECOS_REPOSITORY}devs/eth/arm/iq80310/current/include/iq80310_info.h
> >> defines MAX_RX_DESCRIPTORS and MAX_RX_DESCRIPTORS both to 128 when eCos
> >> is compiled for the target=iq80310 template=net.  However, the amount of
> >> memory that is reserved total for these descriptors appears to only be
> >> 16KB regardless of the number of descriptors defined in iq80310_info.h
> >
> > Looks like you're right IMHO.
> >
> > Mark, I can't test this patch, so in your opinion does it look okay to
> > check-in?
>
> Yes, but there's still this in
> devs/eth/arm/iq80310/current/src/if_iq80310.c:
>
>     // First initialize the heap in PCI window'd memory
>     i82559_heap_size = 16*1024;  // match actual size in if_shmem.S
>
> Ugly, ain't it?
>
> That needs the same calculation as in if_shmem.S.
>
> I'm still trying to think of a good way of using the generic 82559 driver
> while maintaining a minimal PCI window for RedBoot...
>
> --Mark

Why use assembly at all?

If this needs to be on a 4K boundary, just create a function that allocates 
X+4K and round up to the first 4K boundary.  That was what I was considering 
anyhow.  You waste 4K no matter what, but it's portable.

Just my 2cents.

-Rich


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]