This is the mail archive of the
ecos-discuss@sources.redhat.com
mailing list for the eCos project.
Re: [PATCH] Move romboot.S from i386/arch to i386/pc
- To: Ian Campbell <icampbell at arcom dot co dot uk>
- Subject: Re: [ECOS] [PATCH] Move romboot.S from i386/arch to i386/pc
- From: Jonathan Larmour <jlarmour at redhat dot com>
- Date: Fri, 12 Oct 2001 06:51:31 +0100
- Cc: eCos List <ecos-discuss at sources dot redhat dot com>
- References: <1002552849.11365.43.camel@LinuxDev>
Ian Campbell wrote:
[ bit of a delay in replying, sorry ]
> As I mentioned in a previous mail I would like to move the PC romboot
> stuff from the i386/arch package to i386/pc in order to support
> different boot sequences in other platform HALs.
Fair enough.
> The attached patch does this. In addition it changes the
> CYGBLD_BUILD_REDBOOT_BIN option to CYGBLD_BUILD_REDBOOT_BIN_FLOPPY for
> consistency and enables it only if the startup type is FLOPPY, this is
> to avoid the conflicting rules from the two boot methods which both
> produce redboot.bin.
I'm not sure I quite agree with this (or the way it was done before, so
it's not your fault :-)). I prefer the cross-the-board consistency in
naming of this option. So I'm adapting your patch a little so that
CYGBLD_BUILD_REDBOOT_BIN is a component with two mutually exclusive options
within it.
> In addition to applying the patch the files
> romboot.S and romboot.ld need to be moved from hal/i386/arch/current/src
> to hal/i386/pc/current/src which might involve some CVS surgery or a
> remove/add pair or something (I don't know how you guys work this kind
> of thing)..
Will do.
> I have tested as far as compiling images for pc floppy and rom, but I
> have no easy way to test they will actually boot. However the image
> seems to be built in exactly the same way as before my changes, so I
> don't expect there to be a problem.
Famous last words ;).
Note this patch is pushing it in terms of what is an acceptable amount of
changes before worrying about copyright assignments.
Jifl
--
Red Hat, Rustat House, Clifton Road, Cambridge, UK. Tel: +44 (1223) 271062
Maybe this world is another planet's Hell -Aldous Huxley || Opinions==mine