Re: [ECOS] RealTek 8139 on Advantech PCM-5820

[Eric Doenges <Eric dot Doenges at DynaPel dot de>]

Chris Nimmers wrote:
> Files been sent to ecos-patches. For some reason not as 
> attachments but instead included in the e-mail??

The mail I got has both -- the files as attachments and in the mail.
Some (well, two) comments from me:

1. I think the rltk8139_dsr is not necessary, since all it does is
call eth_drv_dsr, which we can do directly. (The code you've added
looks almost exactly like my original code, which I deleted for
the first revision).

2. It would be interesting to see if the driver would work on
the i386 PC target with the ISR like this:

    [ ... ]
    if (!(isr = INW(rltk8139_info->base_address + ISR)))
        return 0;

    /* Clear the interrupt mask to stop the current request. */
    OUTW(0, rltk8139_info->base_address + IMR);

//////****** Chg ->
    /* Acknowledge the interrupt */
    cyg_drv_interrupt_acknowledge(rltk8139_info->vector);
//////****** Chg <-

    return (CYG_ISR_HANDLED | CYG_ISR_CALL_DSR);
    [ ... ]

Since there seem to be different opinions on the correct handling
of interrupts (masking the interrupts on the chip vs. masking the
interrupt on the interrupt controller), I'm thinking of making that
a configuration option.
--
--------------------------------------------------------------------
|     Eric Doenges              |     DynaPel Laboratories GmbH    |
|     Tel: +49 89 962428 23     |     Fraunhoferstrasse 9/2        |
|     Fax: +49 89 962428 90     |     D - 85737 Ismaning, Germany  |
--------------------------------------------------------------------


--
Before posting, please read the FAQ: http://sources.redhat.com/fom/ecos
and search the list archive: http://sources.redhat.com/ml/ecos-discuss