Re: [ECOS] tftp server calls diag_printf()

[Øyvind Harboe <oyvind dot harboe at zylin dot com>]

On Mon, 2004-04-19 at 13:47, Gary Thomas wrote:
> On Mon, 2004-04-19 at 04:32, Øyvind Harboe wrote:
> > I'm working on PPP over a serial line when I discovered that tftp calls
> > diag_printf().
> > 
> > It appears as if I can choose which serial port to send diag output to,
> > but all my serial ports are in use by the application.
> > 
> > Is tftp supposed to call diag_printf() under normal execution?
> 
> Careful examination shows that the TFTP server only calls diag_printf
> for errors. 


?

What about:

tftp_server.c line 669:

#ifndef CYGPKG_NET_TESTS_USE_RT_TEST_HARNESS
	      getnameinfo(&from_addr,sizeof(from_addr), name,
sizeof(name),0,0,0);
	      diag_printf("TFTPD [%x]: received %x from %s\n", p,
			  ntohs(hdr->th_opcode), name);
#endif


>  I'm not sure how you can best handle this if your only
> serial port (diagnostic device) is busy doing PPP.

Is diag_printf() ever supposed to be called during normal execution?

If this is something that is only invoked by eCos when there is a bug
somewhere, then its not really a big problem.

-- 

Øyvind Harboe
http://www.zylin.com




-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss