This is the mail archive of the
ecos-discuss@sources.redhat.com
mailing list for the eCos project.
Re: AT91: fiq patch
- From: Andrew Lunn <andrew at lunn dot ch>
- To: Andrea Michelotti <amichelotti at atmel dot com>
- Cc: Andrew Lunn <andrew at lunn dot ch>, Nick Garnett <nickg at ecoscentric dot com>,ecos-discuss at sources dot redhat dot com
- Date: Thu, 16 Sep 2004 10:01:31 +0200
- Subject: [ECOS] Re: AT91: fiq patch
- References: <021a01c49b48$db552f00$0b0110ac@ipitec.it>
On Wed, Sep 15, 2004 at 07:23:49PM +0200, Andrea Michelotti wrote:
> Hi all,
> I corrected the patch as Andrew suggested.
Its just missing ChangeLog entries now...
> I kept my spurious interrupt detection because I think is more correct and
> quick than the actual one, as explained in my previous mail.
I thought about this some more. I prefer to keep the check as it
was. eCos will have an array of interrupt handlers. If for some reason
the interrupts control returns a value outside of the handled range of
interrupts, its going to access outside of the bounds of the array to
some psuedo random data to get the address of the interrupt handler
and jump off into oblivion. Such problems are very difficult to find
since they are generally hard to reproduce and have nothing to do with
the flow of code currently running. The check means that it will at
least do something controlled and give the programmer some hope of
finding whats wrong.
Andrew
--
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss