This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: patch to fix IPv6 reassembly
- From: Andrew Lunn <andrew dot lunn at ascom dot ch>
- To: Ken Cox <jkc at redhat dot com>
- Cc: ecos-patches at sources dot redhat dot com
- Date: Fri, 26 Jul 2002 14:35:57 +0200
- Subject: Re: patch to fix IPv6 reassembly
- References: <Pine.LNX.4.44.0207260727360.22931-100000@Bigboy>
On Fri, Jul 26, 2002 at 07:29:50AM -0500, Ken Cox wrote:
> ovbcopy() must handle the case where the src and dst regions are
> overlayed. memcpy() does not handle this case, but memmove() does.
Is this a generic assumption of the FreeBSD stack, that the 'kernel'
memcpy deals with overlayed? If so there could be other places in the
stack which also have the same problem.
Rather than fix this one problem, a more generic solution should be
investigated.
Andrew
>
> --- net/bsd_tcpip/current/src/ecos/support.c.orig Wed Jul 24 15:12:39 2002
> +++ net/bsd_tcpip/current/src/ecos/support.c Thu Jul 18 14:56:47 2002
> @@ -625,7 +625,7 @@
> void
> ovbcopy(const void *s, void *d, size_t len)
> {
> - memcpy(d, s, len);
> + memmove(d, s, len);
> }
>
>
>
> --
> Ken Cox
> Communications Software Consultant
> Red Hat, Inc.
> 4900 Corporate Dr.
> Suite L
> Huntsville, AL. 35805
> (256) 217-0142
> (256) 837-0057 (fax)
>
>