Re: cyg_alarm - suggestion for enhancement

[Nick Garnett <nickg at ecoscentric dot com>]

NavEcos <ecos@navosha.com> writes:

> Here are the patches to add the following functions to the KAPI:
> 
> void cyg_alarm_set_callback(
>      cyg_handle_t       alarm,
>      cyg_alarm_t        *alarmfn /* new alarm callback function       */
> );
> 
> cyg_alarm_t *cyg_alarm_get_callback( cyg_handle_t alarm );
> 
> 
> This will make alarms more compatible with vxWorks' watch dog functions
> and make it easier to port from vxWorks to eCos.
> 
> This is such a trivial change that I'm hoping that we can forgo a
> copyright assignment, although my company will be sending a copyright
> assignment to you guys eventually for other changes that we think will
> be useful to the community at large.
> 
> The diffs were tested with the KAPI interface.
> 

There is just one thing I would change.

The functions should set, and return, both the alarm function and the
data value that goes with it. If the function is changed it is likely
that the data will need to change too.


-- 
Nick Garnett - eCos Kernel Architect
http://www.eCosCentric.com/