This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Woops.


On Fri, 2002-10-25 at 18:34, Schumacher, Gordon wrote:
> So much for my first patch... :-S
> 
> The thing that I'm using as SRAM is actually in what eCos is calling "ROM"
> space.  (Per the SA-1100 docs, it's for any ROM, Flash, or SRAM.)
> 
> But, it was still missing banks 4 and 5, so here's a better patch...
> 

Fair enough.  I've committed this patch (since I already put in your
other one!)

Index: hal/arm/sa11x0/var/current/ChangeLog
===================================================================
RCS file: /misc/cvsfiles/ecos/packages/hal/arm/sa11x0/var/current/ChangeLog,v
retrieving revision 1.22
diff -u -5 -p -r1.22 ChangeLog
--- hal/arm/sa11x0/var/current/ChangeLog	25 Oct 2002 20:36:35 -0000	1.22
+++ hal/arm/sa11x0/var/current/ChangeLog	26 Oct 2002 14:02:18 -0000
@@ -1,5 +1,10 @@
+2002-10-26  Gary Thomas  <gthomas@ecoscentric.com> (inspired by)
+2002-10-26  Gordon Schumacher <gordon_schumacher@maxtor.com>
+
+	* include/hal_sa11x0.h: Make ROM/RAM/FLASH space layout clearer.
+
 2002-10-25  Gary Thomas  <gthomas@ecoscentric.com> (inspired by)
 2002-10-25  Gordon Schumacher <gordon_schumacher@maxtor.com>
 
 	* include/hal_sa11x0.h: Add SRAM definitions.
 
Index: hal/arm/sa11x0/var/current/include/hal_sa11x0.h
===================================================================
RCS file: /misc/cvsfiles/ecos/packages/hal/arm/sa11x0/var/current/include/hal_sa11x0.h,v
retrieving revision 1.7
diff -u -5 -p -r1.7 hal_sa11x0.h
--- hal/arm/sa11x0/var/current/include/hal_sa11x0.h	25 Oct 2002 20:36:35 -0000	1.7
+++ hal/arm/sa11x0/var/current/include/hal_sa11x0.h	26 Oct 2002 14:01:38 -0000
@@ -77,18 +77,21 @@
 #endif /* __ASSEMBLER__ */
 
 /*
  * SA11X0 Default Memory Layout Definitions
  */
+// Typically ROM, FLASH
 #define SA11X0_ROM_BANK0_BASE                    (0)
 #define SA11X0_ROM_BANK1_BASE                    (SA11X0_ROM_BANK0_BASE + SZ_128M)
 #define SA11X0_ROM_BANK2_BASE                    (SA11X0_ROM_BANK1_BASE + SZ_128M)
 #define SA11X0_ROM_BANK3_BASE                    (SA11X0_ROM_BANK2_BASE + SZ_128M)
 
-#define SA11X0_SRAM_BANK0_BASE                   (0x40000000)
-#define SA11X0_SRAM_BANK1_BASE                   (SA11X0_SRAM_BANK0_BASE + SZ_128M)
+// May be ROM, FLASH, SRAM, etc
+#define SA11X0_ROM_BANK4_BASE                    (0x40000000)
+#define SA11X0_ROM_BANK5_BASE                    (SA11X0_ROM_BANK4_BASE + SZ_128M)
 
+// Typically DRAM
 #define SA11X0_RAM_BANK0_BASE                    (0xC0000000)
 #define SA11X0_RAM_BANK1_BASE                    (SA11X0_RAM_BANK0_BASE + SZ_128M)
 #define SA11X0_RAM_BANK2_BASE                    (SA11X0_RAM_BANK1_BASE + SZ_128M)
 #define SA11X0_RAM_BANK3_BASE                    (SA11X0_RAM_BANK2_BASE + SZ_128M)
 
-- 
------------------------------------------------------------
Gary Thomas                  |
eCosCentric, Ltd.            |  
+1 (970) 229-1963            |  eCos & RedBoot experts
gthomas@ecoscentric.com      |
http://www.ecoscentric.com/  |
------------------------------------------------------------


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]