This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: [APPROVE?] setbuf fix
- From: Gary Thomas <gary at mlbassoc dot com>
- To: Jonathan Larmour <jlarmour at jifvik dot org>
- Cc: eCos patches <ecos-patches at sources dot redhat dot com>
- Date: 15 Feb 2003 10:21:28 -0700
- Subject: Re: [APPROVE?] setbuf fix
- References: <200302151656.h1FGutG03717@garibaldi.jifvik.org.>
Looks fine to me.
On Sat, 2003-02-15 at 09:56, Jonathan Larmour wrote:
> Index: ChangeLog
> ===================================================================
> RCS file: /cvs/ecos/ecos/packages/language/c/libc/stdio/current/ChangeLog,v
> retrieving revision 1.18
> diff -u -5 -p -r1.18 ChangeLog
> --- ChangeLog 29 Jan 2003 17:27:33 -0000 1.18
> +++ ChangeLog 15 Feb 2003 16:56:54 -0000
> @@ -1,5 +1,10 @@
> +2003-02-15 Fabrice Gautier <Fabrice_Gautier@sdesigns.com>
> +
> + * include/stdio.inl (setbuf): Don't supply size with _IONBF.
> + * src/common/stdioinlines.cxx (setbuf): Ditto.
> +
> 2003-01-29 Jonathan Larmour <jifl@eCosCentric.com>
>
> * src/output/vfnprintf.cxx: Add support for C99 'z' flag (size_t).
>
> 2002-09-02 Andrew Lunn <andrew.lunn@ascom.ch>
> Index: include/stdio.inl
> ===================================================================
> RCS file: /cvs/ecos/ecos/packages/language/c/libc/stdio/current/include/stdio.inl,v
> retrieving revision 1.3
> diff -u -5 -p -r1.3 stdio.inl
> --- include/stdio.inl 23 May 2002 23:07:13 -0000 1.3
> +++ include/stdio.inl 15 Feb 2003 16:56:54 -0000
> @@ -75,11 +75,11 @@
>
> extern __inline__ void
> setbuf( FILE *stream, char *buf )
> {
> if (buf == NULL)
> - setvbuf( stream, NULL, _IONBF, BUFSIZ );
> + setvbuf( stream, NULL, _IONBF, 0 );
> else
> // NB: Should use full buffering by default ordinarily, but in
> // the current system we're always connected to an interactive
> // terminal, so use line buffering
> setvbuf( stream, buf, _IOLBF, BUFSIZ );
> Index: src/common/stdioinlines.cxx
> ===================================================================
> RCS file: /cvs/ecos/ecos/packages/language/c/libc/stdio/current/src/common/stdioinlines.cxx,v
> retrieving revision 1.3
> diff -u -5 -p -r1.3 stdioinlines.cxx
> --- src/common/stdioinlines.cxx 23 May 2002 23:07:17 -0000 1.3
> +++ src/common/stdioinlines.cxx 15 Feb 2003 16:56:54 -0000
> @@ -80,11 +80,11 @@
>
> externC void
> setbuf( FILE *stream, char *buf )
> {
> if (buf == NULL)
> - setvbuf( stream, NULL, _IONBF, BUFSIZ );
> + setvbuf( stream, NULL, _IONBF, 0 );
> else
> // NB: Should use full buffering by default ordinarily, but in
> // the current system we're always connected to an interactive
> // terminal, so use line buffering
> setvbuf( stream, buf, _IOLBF, BUFSIZ );
--
------------------------------------------------------------
Gary Thomas |
MLB Associates | Consulting for the
+1 (970) 229-1963 | Embedded world
http://www.mlbassoc.com/ |
email: <gary@mlbassoc.com> |
gpg: http://www.chez-thomas.org/gary/gpg_key.asc
------------------------------------------------------------