This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: H8/300 update


Yoshinori Sato <ysato at users dot sourceforge dot jp> writes:

> h8s_support.diff : new variant H8S support
> aki3068net.diff  : target aki3068net update
> h8max.diff       : new target H8MAX support
> edosk2674.diff   : new target EDOSK-2674R support
> db.diff          : ecos.db update
> 

Hi,

I've been looking at these patches to see how easily we can import
them into the repository. Unfortunately I have found a couple of
problems.


1. When you added the H8S support you moved some code from the
   architecture HAL to the variant HALs. The new H8S HAL has the new
   stuff in it, but these patches do not contain the necessary changes
   to the h8300h package to allow it to work. I'm sure you just forgot
   to add it.

2. I've also had problems building the h8s targets, I get an error
   saying that CYGNUM_HAL_H8300_H8300H_SCI_BAUD_RATE is undefined.


I've not investigated either of these very deeply. And I am not sure
whether these patches are in addition to any previous patches, or
replace them. There seems to be a lot of overlap, and a lot of
variations.

I think that the easiest way of getting this sorted out is if you
could send me a completely new patch against the current CVS
repository. A "cvs diff" from the level of the packages directory
would be best, so that it contains all the new packages and changes to
existing packages.


Thanks in advance.

-- 
Nick Garnett                    eCos Kernel Architect
http://www.ecoscentric.com/     The eCos and RedBoot experts


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]