This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: [APPROVE?] Fix spurious interrupt on mpc8xx
- From: Gary Thomas <gary at mlbassoc dot com>
- To: Jonathan Larmour <jifl at eCosCentric dot com>
- Cc: eCos Patches List <ecos-patches at sources dot redhat dot com>
- Date: 31 Mar 2003 04:27:15 -0700
- Subject: Re: [APPROVE?] Fix spurious interrupt on mpc8xx
- References: <3E87DCD8.6000307@eCosCentric.com>
On Sun, 2003-03-30 at 23:14, Jonathan Larmour wrote:
> The attached patch fixes a spurious interrupt with asserts enabled when
> using the serial port on viper. It also does some very minor cleanups.
>
> I haven't checked it in to the trunk, just in case there's some other
> reasoning for the way things was that I've missed (although I doubt it),
> but if it's okay, I would also like approval for the 2.0 branch.
>
I think that these are fine, although the removal of the call to
CPM_reset is a no-op (it should be done by the variant code and
then only once, so it has no real effect except for documentation).
BTW I've yet to see the spurious interrupt that you are chasing when
using a newer RedBoot (probably even one built from the current branch).
--
------------------------------------------------------------
Gary Thomas |
MLB Associates | Consulting for the
+1 (970) 229-1963 | Embedded world
http://www.mlbassoc.com/ |
email: <gary at mlbassoc dot com> |
gpg: http://www.chez-thomas.org/gary/gpg_key.asc
------------------------------------------------------------