This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: edb7211 flash without ...
note: subject changed, because previous message bounced as SPAM!
On Tue, 2003-04-01 at 07:34, Jani Monoses wrote:
>
> > I'll be glad to review the changes (and even more glad to purge all
> > old drivers!). The only problem is testing, which I will have to
> > leave to you (I assume that since you are sending such patches, you
> > have access to this hardware).
> To this hardware yes but not to the others which still don't use generic
> drivers.
>
I was only asking about this particular [class of] platform. I wasn't
proposing that you try and fix all of the non-generic FLASH drivers :-)
> > > Only with the cache macros in is the code in 28F equivalent to edb
> >
> > I think this may be because I had some trouble with the cache (it
> > didn't seem to ever turn off). Maybe you can isolate this and get it
> > fixed while you make these changes.
>
> I never tested it heavier than causal FIS usage and it seemed to work
> with and without the
> cache macros is 28F.
Precisely - I think because the upper layer is already managing
the cache properly.
>
> > I think the StrataFlash driver is the one to use - it's very flexible
> > and can handle most any of that family of devices. I'm also pretty
> > sure that it does 100% supercede the "bootblock" driver.
>
> Then maybe deleting bootblock from the repo would stop somebody accidentaly use it :)
>
This should be considered.
> > As for your changes below, I don't think they are required. The upper
> > level of the driver (io/flash/...) handles the caches fully so that
> > the physical drivers never need bother with it.
>
> That's great so does that mean that no low level drivers need to touch
> the cache?
> A grep DCACHE_ENABLE -r devs/flash/ shows that there are still some
> users including the intel drivers.
I'll take a look at this.
--
------------------------------------------------------------
Gary Thomas |
MLB Associates | Consulting for the
+1 (970) 229-1963 | Embedded world
http://www.mlbassoc.com/ |
email: <gary at mlbassoc dot com> |
gpg: http://www.chez-thomas.org/gary/gpg_key.asc
------------------------------------------------------------