Re: Intel FLASH

[Jani Monoses <jani at iv dot ro>]

On Fri, 3 Oct 2003 16:59:23 -0400 
"Doyle, Patrick" <WPD@dtccom.com> wrote:

> OK folks,
> Attached is my rework of the strata device driver.  As often happens
> with
[...]
> I wonder if my changes are significant enough, or the risk of breaking
> existing platforms is high enough, that I should change this to an
> entirely new device driver, perhaps intel/cfiflash, or something like
> that; perhaps even move it up one layer in the tree, since it is
> nolonger specific to Intel -- in theory any flash that implents CFI
> should work with this.

I think it would be better to not make yet another driver. Even if your
changes are invasive they can't break thing too much especially if
they're tested. Here's my changes against your patch to make it compile
with my two configs I tested with. In the UNLOCK_SINGLE_BLOCKS turned
off case there were some vars missing. 
I also moved the new block_op in strata.c and made it not inline. It is
relatively big so calling it saves some space but more importanatly
since it is not guarranteed that it is inlined even if you tell gcc to
try it can end up not in .2ram section so relocations truncated errors
are given at linkage.That's what happened  here anyway. I put it in
.2ram as well.I changed the bootblock detection to work with SERIES and
with the B3 device.
So far with these changes it seems to work on the B3 and W3 parts I have
here.I'll keep testing though.

Jani

Attachment: pd.diff
Description: Text document