This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: romfs_mount wrongly returns ENOENT under certain conditions.
- From: Gary Thomas <gary at mlbassoc dot com>
- To: Andrew Lunn <andrew at lunn dot ch>
- Cc: sandeep <sandeep at codito dot com>, ecos-patches at sources dot redhat dot com
- Date: 11 Dec 2003 06:30:03 -0700
- Subject: Re: romfs_mount wrongly returns ENOENT under certain conditions.
- Organization: MLB Associates
- References: <004801c3bfc4$326aef70$2564a8c0@blackmagic> <20031211125456.GU2527@lunn.ch>
On Thu, 2003-12-11 at 05:54, Andrew Lunn wrote:
> On Thu, Dec 11, 2003 at 02:23:07PM +0530, sandeep wrote:
> > Changelog :
> > * src/romfs.c (romfs_mount) : function wrongly returns ENOENT even if
> > fste->data isn't NULL.
> >
> > Problem :
> > if ( !disk ) {
> > // If still no address, try the FSTAB entry data word
> > -- mte->data = fste->data;
> > ++ disk = (romfs_disk *)fste->data;
> > }
> >
> > if ( !disk ) {
> > // If still no address, give up...
> > return ENOENT;
> > }
> >
> > you will wrongly return ENOENT if disk happened to be NULL at the time of first
> > if-check though fste->data isn't NULL. attached patch corrects it.
>
> I've committed this patch,
> Thanks
> Andrew
There seems to have been a change in function here. Isn't the value
of "mte->data" important? If so, it's no longer being set.
--
Gary Thomas <gary@mlbassoc.com>
MLB Associates