This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Øyvind Harboe <oyvind.harboe@zylin.com> writes: > A ppp chat script did not return success when it ran to completion. Hmmm, it looks like at some point I was trying to decide whether this function should return true/false or 0=success/!0=fail and left it somewhere in the middle. > > I also changed cyg_ppp_chat_success to be a local variable as I could > see no reason why it should be a static variable. > This is probably an hangover from an expectation that some of the called functions might need to change this. Hence the test in the loop condition. I've checked in a slightly munged version of your patch (attached), and added a paragraph to the documentation.
Attachment:
ppp.chat
Description: PPP Chat fix
-- Nick Garnett eCos Kernel Architect http://www.ecoscentric.com The eCos and RedBoot experts
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |