This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: fatfs and io disk misc patches
- From: Andrew Lunn <andrew at lunn dot ch>
- To: Savin Zlobec <savin at elatec dot si>
- Cc: ecos-patches at sources dot redhat dot com
- Date: Tue, 29 Jun 2004 18:33:14 +0200
- Subject: Re: fatfs and io disk misc patches
- References: <40DA9B63.9000200@elatec.si>
On Thu, Jun 24, 2004 at 11:14:11AM +0200, Savin Zlobec wrote:
> +2004-06-24 Savin Zlobec <savin@elatec.si>
> +
> + * src/synthdisk.c:
> + Removed static keyword before DISK_CHANNEL macro (which
> + has changed).
> +
> 2004-01-15 Nick Garnett <nickg@calivar.com>
>
> * cdl/synthdisk.cdl:
> Index: devs/disk/synth/current/src/synthdisk.c
> ===================================================================
> RCS file: /cvs/ecos/ecos/packages/devs/disk/synth/current/src/synthdisk.c,v
> retrieving revision 1.1
> diff -u -w -r1.1 synthdisk.c
> --- devs/disk/synth/current/src/synthdisk.c 19 Jan 2004 14:35:01 -0000 1.1
> +++ devs/disk/synth/current/src/synthdisk.c 24 Jun 2004 08:38:44 -0000
> @@ -123,7 +123,7 @@
> filefd: -1, \
> filename: CYGDAT_IO_DISK_ECOSYNTH_DISK##_number_##_FILENAME \
> }; \
> -static DISK_CHANNEL(synth_disk_channel##_number_, \
> +DISK_CHANNEL(synth_disk_channel##_number_, \
> synth_disk_funs, \
> synth_disk_info##_number_, \
> _mbr_supp_ \
I don't know if this is the correct fix. You polute the name space. I
don't think synth_disk##_number_ needs to be a global symbol, so
static is correct. The macro defines two variables and only the first
is being made static. Probably there needs to be two macros, one for
the cyg_disk_info_t variable and a second for the dock_channel.
It looks like there are a few other name space polution problems as
well. There are some types without cyg_ prefixes. It would be nice to
clean this up.
Andrew