This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: Patch for negotiating ACCM and accepting a NULL PAP password.
- From: Nick Garnett <nickg at ecoscentric dot com>
- To: Parvathaneni Murali <PMurali at hypercom dot com>
- Cc: ecos-patches at sources dot redhat dot com,Matt Jerdonek <MJerdonek at hypercom dot com>, Murkrisp at yahoo dot com
- Date: 24 Nov 2004 11:48:18 +0000
- Subject: Re: Patch for negotiating ACCM and accepting a NULL PAP password.
- References: <OF7DCAB19D.B55DCC41-ON07256F51.0080E6A1-07256F51.0081125D@hypercom.com>
Parvathaneni Murali <PMurali@hypercom.com> writes:
> The attached patch file has been created from the "net" directory under ecos/packages and it has
> changes for negotiation ACCM when using PPP and also for accepting a NULL value for PAP password.
> Please let me know if these changes are acceptable.
I'm not happy about this.
I'm not sure that doing PAP with a NULL password is in the spirit of
how these protocols should be used. Either you should set refuse_pap,
or use a proper password. The original PPPD code doesn't allow a NULL
password for a reason, we should respect that.
ACCM negotiation should be an option settable in cyg_ppp_options_t. It
shouldn't be on by default. At the same time the actual map being
negotiated should be settable too. This should all follow the way that
the original PPPD code handles options.
--
Nick Garnett eCos Kernel Architect
http://www.ecoscentric.com/ The eCos and RedBoot experts