This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Patch for negotiating ACCM and accepting a NULL PAP password.

From: Parvathaneni Murali <PMurali at hypercom dot com>
To: nickg at ecoscentric dot com
Cc: ecos-patches at sources dot redhat dot com, MJerdonek at hypercom dot com, Murkrisp at yahoo dot com, nickg at xl5 dot calivar dot com
Date: Wed, 1 Dec 2004 12:29:36 -0700
Subject: Re: Patch for negotiating ACCM and accepting a NULL PAP password.

Hello Nick,

Thank you for your valuable comments. I had to make PAP work with a NULL password because that
was a requirement for T-Mobile/Voicestream's wireless internet connection. I guess I will have to
work around that issue with the ISP.

As per your suggestion, I have made ACCM negotiation a configurable option. The attached patch file
details the changes and it has been created from the "net" directory again. Please let me know if
they were what you intended to see.

(See attached file: confoptnegaccm.txt)

Murali @ (602) 504-4962.

nickg@ecoscentric
.com To: PMurali@hypercom.com
Sent by: cc: ecos-patches@sources.redhat.com, MJerdonek@hypercom.com, Murkrisp@yahoo.com
nickg@xl5.calivar Subject: Re: Patch for negotiating ACCM and accepting a NULL PAP password.
.com

11/24/2004 04:48
AM

Parvathaneni Murali <PMurali@hypercom.com> writes:

> The attached patch file has been created from the "net" directory under ecos/packages and it has
> changes for negotiation ACCM when using PPP and also for accepting a NULL value for PAP password.
> Please let me know if these changes are acceptable.

I'm not happy about this.

I'm not sure that doing PAP with a NULL password is in the spirit of
how these protocols should be used. Either you should set refuse_pap,
or use a proper password. The original PPPD code doesn't allow a NULL
password for a reason, we should respect that.

ACCM negotiation should be an option settable in cyg_ppp_options_t. It
shouldn't be on by default. At the same time the actual map being
negotiated should be settable too. This should all follow the way that
the original PPPD code handles options.

--
Nick Garnett eCos Kernel Architect
http://www.ecoscentric.com/ The eCos and RedBoot experts

Attachment: confoptnegaccm.txt
Description: Binary data

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]