This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: eCos jffs2 garbage collection thread + fix


On Tue, Jan 11, 2005 at 09:23:52AM +0100, Andrew Lunn wrote:
> > I have updated my patch. I solved the problem with a reference to the mte by
> > saving a reference at mount time and make sure that this reference is valid
> > after umount in case of multiple mount/umount (Not tested). It is maybe not
> > the best solution but it seams to work.
> 
> It should work, but its a bit messy. I don't like breaking the
> filesystem mount point abstration like this. At minimum i would move
> your lookup code out of the filesystem into the io package and add a
> function something like 
> 
> struct cyg_mtab_entry * cyg_fs_root_lookup(cyg_dir *root);
> 
> I was hoping Nick would comment about this since its his design. Maybe
> there is a better way to do this.

Here is what i intend to commit in the next few days if no one says
otherwise.

I've added a new test which will exersise the garbage collect code. IT
shows there is a memory leak somewhere. I've not yet spent time to
track the leak down.

I've not been keeping track to jffs2, but i recently notices jffs3 has
been fored from the jffs2 code. It looks like only bug fixes will be
added to jffs2 from now on. So i will try to find time the import an
up to date version of jffs2. Hopefully jffs2 will then no longer be
such a moving target and we can get any remaining eCos bugs fixed.

        Andrew

Attachment: fileio.diff
Description: Text document

Attachment: jffs2.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]