This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: Object File Loader
- From: Jani Monoses <jani at iv dot ro>
- To: ecos-patches at sources dot redhat dot com
- Date: Wed, 29 Jun 2005 09:07:51 +0300
- Subject: Re: Object File Loader
- References: <m3br5qweva.fsf@xl5.calivar.com>
A couple minor observations.
--- anoncvs_clean/ecos/packages/services/objloader/current/cdl/objloader.cdl 1970-01-01 01:00:00.000000000 +0100
+++ anoncvs_patch/ecos/packages/services/objloader/current/cdl/objloader.cdl 2005-06-28 16:24:15.000000000 +0100
[...]
+
+cdl_package CYGPKG_OBJLOADER {
+ display "Object file loader"
+ description "This package provides support for loading and relocating
+ object files withing eCos."
+ include_dir cyg/objloader
+ include_files elf.h objelf.h loader_fs.h relocate_ppc.h
+ compile objloader.c objelf.c loader_fs.c
+ requires CYGPKG_MEMALLOC
+ requires CYGPKG_IO_FILEIO
+# ====================================================================
+
+ cdl_component CYGPKG_SERVICES_OBJLOADER_ARCHITECTURE {
+ display "Architecture dependent settings"
+ flavor none
+ no_define
+ description "."
+
+ cdl_option CYGBLD_OBJLOADER_ARCHITECTURE_POWERPC {
+ display "Support loading on PowerPC processors"
+ calculated CYGPKG_HAL_POWERPC
+ define_proc {
+ puts $::cdl_header "#include <cyg/objloader/relocate_ppc.h>"
+ }
+ compile relocate_ppc.c
+ }
+
+# cdl_option CYGBLD_OBJLOADER_ARCHITECTURE_ARM {
+# display "Support loading on ARM processors"
+# calculated CYGPKG_HAL_ARM
+# define_proc {
+# puts $::cdl_header "#include <cyg/objloader/relocate_arm.h>"
+# }
+# compile relocate_arm.c
+# }
+# }
look like an extra brace is commented out here, making all subsequent options be under the
architecture component and needing an extra closing brace at the end.
...
diff -r -U5 -N -X /home/nickg/diffex anoncvs_clean/ecos/packages/services/objloader/current/ChangeLog anoncvs_patch/ecos/packages/services/objloader/current/ChangeLog
--- anoncvs_clean/ecos/packages/services/objloader/current/ChangeLog 1970-01-01 01:00:00.000000000 +0100
+++ anoncvs_patch/ecos/packages/services/objloader/current/ChangeLog 2005-06-28 16:22:31.163780522 +0100
[...]
+// Alternative licenses for eCos may be arranged by contacting Red Hat, Inc.
+// at http://sources.redhat.com/ecos/ecos-license/
the redhat line sneaked in this file :)
also cyg/kernel/kapi.h is included in several files even if there's no explicit dependency
on the KERNEL package in the CDL, and I didn't see use of kernel functions in the code
except in the tests.
Jani
Jani