This is the mail archive of the ecos-patches@sourceware.org mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Philips D12 USB Slave Driver


Hi Frank

On Tue, Apr 11, 2006 at 09:35:28AM -0400, Frank Pagliughi wrote:
> This is a driver for the Philips PDIUSBD12 (D12) USB Slave Controller 
> Chip. It was written for the D12 on a PC/104 (ISA) board. With some 
> minor adjustments and testing should go with any CPU. I (tried to) 
> removed all the board-specific stuff, which, unfortunately also meant 
> removing DMA support.

I just had a very quick look at the code. I does seem to have a few
x386ism's in it but they are all nicely abstracted. Do you think you
can split this into two packages. A generic D12 driver and an i386
specific part. It would contain the functions to actually access the
hardware. You could put these into an inline header file so there
would be no loss of performance.

I noticed there is also an extensive test program. What is required on
the host to run this test?

> A similar driver for the Philips ISP1181 is being tested and should be 
> delivered within a few weeks.

Sounds good.

We will need a copyright asignement in order to incorperate this into
eCos. Please could you take a look at:

http://ecos.sourceware.org/assign.html

        Thanks
                Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]