This is the mail archive of the ecos-patches@sourceware.org mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: LPC2XXX interrupt_acknowledge


Hi Andrew,

I've just looked at this properly and I think the change should be:

#ifdef CYGHWR_HAL_ARM_LPC2XXX_FAMILY_LPC22XX
   lpc_set_vpbdiv(CYGNUM_HAL_ARM_LPC2XXX_VPBDIV,
                  CYGNUM_HAL_ARM_LPC2XXX_XCLKDIV);
#else
   lpc_set_vpbdiv(CYGNUM_HAL_ARM_LPC2XXX_VPBDIV, 0);
#endif

rather than:

#ifdef CYGHWR_HAL_ARM_LPC2XXX_FAMILY_LPC22XX
   lpc_set_vpbdiv(CYGNUM_HAL_ARM_LPC2XXX_VPBDIV,
                  CYGNUM_HAL_ARM_LPC2XXX_XCLKDIV);
#endif

otherwise VPBDIV isn't set for non LPC22xx platforms. Do you want a patch for this?

Apologies for not dealing with this in the original patch.

Andy..

----- Original Message ----- From: "Andrew Lunn" <andrew@lunn.ch>
To: "Andy Jackson" <andy@xylanta.com>
Cc: <ecos-patches@ecos.sourceware.org>; "Sergei Gavrikov" <sg@belvok.com>
Sent: Sunday, May 07, 2006 7:42 PM
Subject: Re: LPC2XXX interrupt_acknowledge



On Sat, May 06, 2006 at 08:58:01AM +0100, Andy Jackson wrote:
Hi,

2. it adds support for XCLK on the LPC22xx parts and makes the VPB and
XCLK dividers CDL configurable.

This broke targets other than LPC22XX. CYGNUM_HAL_ARM_LPC2XXX_XCLKDIV is only active with LPC22XX, but hal_hardware_init() used it unconditionally.

Also, please could you set your editor to insert spaces, not tabs. I
had to re-indent all the changes you made to make the indentation
correct.

I've committed the fixed patch.

Thanks
Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]