This is the mail archive of the ecos-patches@sourceware.org mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Speed-up sprintf() family of functions.


> >Another way to "fix" it is:
> >
> >-    return vfnprintf( (FILE *)&stream, size, format, arg );
> >+    return vfnprintf( (FILE *)(void*)&stream, size, format, arg );
> >
> >is it "correct" fix?
> 
> "Correct", no. But I take your point about not actually dereferencing the 
> pointer here, so aliasing is never, in practice, going to be an issue. So 
> let's just go with this one, since it's simple. I'm about to go offline 
> for an extended period, so it can wait for me to return, or perhaps Andrew 
> can check it in with just that change.

I've committed the patch with the added (void *).

     Thanks
        Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]