Re: LPC2xxx patch for support of vectored interrupt controller

[Hans Rosenfeld <rosenfeld at grumpf dot hope-2000 dot org>]

On Tue, Aug 21, 2007 at 08:10:59AM +0200, cetoni GmbH - Uwe Kindler wrote:
> I dont't agree with this change. If I configure a system and do a 
> mistake setting up interrupt priorities then my only chance and a very 
> good way to catch this error is this assertion. If you silently drop 
> this failure just to make a test case happy then you may pass the test 
> but you will run into trouble with your real application.

This function is not used for setting up priorities, but for interrupt
polarity and mode, which is only valid for the external interrupts.
I doubt anyone would even think about changing the polarity of an
internal interrupt or would try to use an internal interrupt for some
external devices by accident, except for code like the test case that
doesn't know and doesn't care. 

But, maybe the code should emit a warning if it is attempted.

> Btw. the assertion I put into the code is wrong:
> 
> CYG_ASSERT(vector <= CYGNUM_HAL_INTERRUPT_EINT3 &&
>            vector >= CYGNUM_HAL_INTERRUPT_EINT0 , "Invalid vector");
> 

I'm pretty sure this is correct.


-- 
%SYSTEM-F-ANARCHISM, The operating system has been overthrown