Re: Pedantic preprocessor

[Sergei Organov <osv at javad dot com>]

Sergei Gavrikov <w3sg@SoftHome.net> writes:
> On Tue, Oct 16, 2007 at 01:18:04PM +0400, Sergei Organov wrote:
>> Gary Thomas <gary@mlbassoc.com> writes:
>> > Sergei Gavrikov wrote:
>> [...]
>> >> ecosconfig new sam7ex256
>> >> ecosconfig tree
>> >> make -s
>> >> U CYGHWR_HAL_ARM_AT91, new inferred value AT91SAM7S
>> >> U CYGHWR_HAL_ARM_AT91_FIQ, new inferred value 1
>> >> U CYGHWR_HAL_ARM_AT91SAM7, new inferred value at91sam7x256
>> >> headers finished
>> >> cc1: warning: command line option "-Woverloaded-virtual" is valid for C++/ObjC++ but not for C
>> >> cc1: warning: command line option "-fno-rtti" is valid for C++/ObjC++ but not for C
>> >> cc1: warning: command line option "-Woverloaded-virtual" is valid for C++/ObjC++ but not for C
>> >> cc1: warning: command line option "-fno-rtti" is valid for C++/ObjC++ but not for C
>> >> cc1: warning: command line option "-Woverloaded-virtual" is valid for C++/ObjC++ but not for C
>> >> cc1: warning: command line option "-fno-rtti" is valid for C++/ObjC++ but not for C
>> >> build finished
>> >>
>> [...]
>> >> I like to see these 2 lines together. And if anybody knows how to fix
>> >> this issue in platform CDL, please, enlight me.
>> >>   
>> > Your patch is the correct one - I've applied it.  Next time, don't
>> > forget the ChangeLog entry.
>> 
>> Is there anybody here who is willing/capable to fix the rest of HALs the
>> same way, as every HAL in eCos suffers from the same problem (e.g., I
>> recently happened to do the same thing for SPARC HAL)?
>
> I wouldn't risk to patch all arch. CDLs vis-a-vis, sorry. IMO, this is
> the experts's deal.  I uses the toolchains for arm and i386 targets
> only. And as I said, the CPP from a pretty old, but the stable GCC suite
> (3.2.1) quite builds eCos for my targets without any warnings.

That's the case for most of us, I think, -- we only have 1--2 toolchains
in use and can't easily test global patch.

> Though, I think since the ecoscentric has offered the GCC 3.4.4 suite
> for own customers, they have done something like that receipt already.
> If they would confirm our way, so the someone's deal will be just a
>
>   s/CFLAGS/ACTUAL_&/g

My guess is that at some point somebody introduced ACTUAL_CFLAGS making
use of CFLAGS obsolete, but missed the issue that quite a few of CDLs
need to be patched accordingly, so it should be just a dumb
search-and-replace issue indeed.

> otherwise, a group of the testers are wanted: 
>
>   find $ECOS_REPOSITORY -regex '.*/arch/.*/cdl/hal.*cdl' | wc -l
>
> ... So, submit the same patch for SPARC, please, if you've tested it.

It's not trivial for me as I work with rather customized eCos tree, and
it takes some effort to rebase the patch w.r.t anonymous CVS eCos tree
and then test it. Not worth it for partial solution of a minor issue. I
just hoped it's relatively easy for somebody with comprehensive set of
toolchains to do s/CFLAGS/ACTUAL_CFLAGS/ and then test it.

-- 
Sergei.