This is the mail archive of the ecos-patches@sourceware.org mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug 1000572] SPEArNet port


http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000572





--- Comment #4 from Andrew Lunn <andrew.lunn@ascom.ch>  2008-07-10 15:38:54 ---
Hi Vitali

Now that the copyright assignment is done i have a few comments.

I had a quick look at the ST site about this processor. It seems there are
actually a family of SPEAR processors of which the NET is just one.

How much is shared between these devices? Should some of these new packages be
made more generic? Do we want to name the ethernet driver and the serial driver
just SPEAR because they can be used with other processors in the family?

I also think that your HAL might be better if it was split up into two
packages. A generic SPEARNET package which contains SPEAR-NET specific code and
a board specific HAL package which contains details about the board, ie how
much RAM, ROM,  LED debug routines etc. This split makes it easier for somebody
to do a port to a different development board etc.

I have a few other minor comments, but they are not important at the moment.

    Andrew




-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]