This is the mail archive of the
ecos-patches@sourceware.org
mailing list for the eCos project.
Re: patch feedback
- From: Nick Garnett <nickg at ecoscentric dot com>
- To: "Spencer Oliver" <spen at spen-soft dot co dot uk>
- Cc: "'John Dallaway'" <john at dallaway dot org dot uk>, <ecos-patches at ecos dot sourceware dot org>
- Date: 10 Dec 2008 10:12:51 +0000
- Subject: Re: patch feedback
- References: <20081210100005.C0767138766@xl5.calivar.com>
"Spencer Oliver" <spen@spen-soft.co.uk> writes:
> > >> While i understand everyone is busy, feedback is always
> > appreciated.
> > >>
> > >> http://ecos.sourceware.org/ml/ecos-patches/2008-11/msg00117.html
> > >
> > > I will look at this one shortly. Thank you for the patch...
> >
> > Now checked in. I renamed the event handler function for consistency.
> >
>
> Many Thanks.
>
> Any chance you could get the other one looked at aswell:
> http://ecos.sourceware.org/ml/ecos-patches/2008-11/msg00109.html
> It fixes a selection bug with the stm32 memory layout when using the
> configtool.
Spencer,
I've taken a look at this. The change is fine. However, there can be
issues around switching major aspects of a confguration like this. The
libraries and other things don't always get rebuilt properly. For this
reason I never do it and prefer to reconfigure from scratch.
I was waiting until there were more Cortex-M patches to check in and
do them in a block. Unfortunately no more have turned up. So I'll
check it in sometime today.
--
Nick Garnett eCos Kernel Architect
eCosCentric Limited http://www.eCosCentric.com The eCos experts
Barnwell House, Barnwell Drive, Cambridge, UK. Tel: +44 1223 245571
Registered in England and Wales: Reg No: 4422071