This is the mail archive of the
ecos-patches@sourceware.org
mailing list for the eCos project.
Re: SPI lpc2xxx patch
- From: Sergei Gavrikov <sg at belvok dot com>
- To: Jonathan Larmour <jifl at eCosCentric dot com>
- Cc: eCos patches list <ecos-patches at ecos dot sourceware dot org>
- Date: Tue, 17 Feb 2009 09:41:11 +0200
- Subject: Re: SPI lpc2xxx patch
- References: <20090127095745.GA7915@sg-ubuntu.local> <499A0AD0.6090004@eCosCentric.com>
On Tue, Feb 17, 2009 at 12:54:40AM +0000, Jonathan Larmour wrote:
> Sergei Gavrikov wrote:
> >Hi
> >
> >I never try SPI driver for lpc2xxx before, today I did and found an
> >annoyance copy & paste typo in spi_lpc2xxx_set_config(). Also, to be
> >ensure the SPI interrupts are using different, was entered a priority
> >selector, like that was done for the lpc2xxx serial driver.
>
> Thanks for the patch. I've checked it in with some minor mods, primarily
> placing the new options under the relevant bus options, renaming them
> consistently with that, and making the bus options components.
I brief check it and got a compile error. There are two undefined CDL
names: cdl_option CYGNUM_IO_SPI_ARM_LPC2XXX_BUS{0,1}_INTPRIO instead
SPI{0,1}. It looks like a copy & paste typo. I prefer no Changelog
this. Fix it, please.
Thank you.
Sergei
Index: devs/spi/arm/lpc2xxx/current/cdl/spi_lpc2xxx.cdl
===================================================================
RCS file: /cvs/ecos/ecos/packages/devs/spi/arm/lpc2xxx/current/cdl/spi_lpc2xxx.cdl,v
retrieving revision 1.4
diff -U5 -r1.4 spi_lpc2xxx.cdl
--- devs/spi/arm/lpc2xxx/current/cdl/spi_lpc2xxx.cdl 17 Feb 2009 00:52:58 -0000 1.4
+++ devs/spi/arm/lpc2xxx/current/cdl/spi_lpc2xxx.cdl 17 Feb 2009 07:30:29 -0000
@@ -63,11 +63,11 @@
default_value 1
description "The LPC2xxx controllers contain two SPI interfaces.
Enable this component to get support for SPI
interface 0."
- cdl_option CYGNUM_IO_SPI_ARM_LPC2XXX_BUS0_INTPRIO {
+ cdl_option CYGNUM_IO_SPI_ARM_LPC2XXX_SPI0_INTPRIO {
display "Interrupt priority of the SPI bus 0 ISR"
flavor data
legal_values 0 to 15
default_value 12
requires { is_active(CYGNUM_IO_SPI_ARM_LPC2XXX_SPI1_INTPRIO)
@@ -87,11 +87,11 @@
default_value 1
description "The LPC2xxx controllers contain two SPI interfaces.
Enable this component to get support for SPI
interface 1."
- cdl_option CYGNUM_IO_SPI_ARM_LPC2XXX_BUS1_INTPRIO {
+ cdl_option CYGNUM_IO_SPI_ARM_LPC2XXX_SPI1_INTPRIO {
display "Interrupt priority of the SPI bus 1 ISR"
flavor data
legal_values 0 to 15
default_value 13
description "