This is the mail archive of the
ecos-patches@sourceware.org
mailing list for the eCos project.
Re: SPI lpc2xxx patch
On Tue, Feb 17, 2009 at 09:09:55AM +0000, Jonathan Larmour wrote:
> Sergei Gavrikov wrote:
> >On Tue, Feb 17, 2009 at 12:54:40AM +0000, Jonathan Larmour wrote:
> >
> >>Sergei Gavrikov wrote:
> >>
> >>>Hi
> >>>
> >>>I never try SPI driver for lpc2xxx before, today I did and found an
> >>>annoyance copy & paste typo in spi_lpc2xxx_set_config(). Also, to be
> >>>ensure the SPI interrupts are using different, was entered a priority
> >>>selector, like that was done for the lpc2xxx serial driver.
> >>
> >>Thanks for the patch. I've checked it in with some minor mods, primarily
> >>placing the new options under the relevant bus options, renaming them
> >>consistently with that, and making the bus options components.
> >
> >
> >I brief check it and got a compile error. There are two undefined CDL
> >names: cdl_option CYGNUM_IO_SPI_ARM_LPC2XXX_BUS{0,1}_INTPRIO instead
> >SPI{0,1}. It looks like a copy & paste typo. I prefer no Changelog
> >this. Fix it, please.
>
> It should have been the other way round to make the option named
> consistently with its parent. Fixed anyway.
Now compiling is okay. But, there is a mixture of {BUS,SPI}._INTPRIO in
CDL file:
requires { is_active(CYGNUM_IO_SPI_ARM_LPC2XXX_SPI1_INTPRIO)
implies (CYGNUM_IO_SPI_ARM_LPC2XXX_SPI0_INTPRIO !=
CYGNUM_IO_SPI_ARM_LPC2XXX_SPI1_INTPRIO)
}
It seems for me the below must be applied for CDL too
s/SPI0_INTPRIO/BUS0_INTPRIO/
s/SPI1_INTPRIO/BUS1_INTPRIO/
or may be I misunderstand something. Thanks.
Sergei