This is the mail archive of the
ecos-patches@sourceware.org
mailing list for the eCos project.
Re: fix thread instrumentation parameters
- From: John Dallaway <john at dallaway dot org dot uk>
- To: Pieter-Jan Busschaert <pieterjan dot busschaert at gmail dot com>
- Cc: ecos-patches at ecos dot sourceware dot org
- Date: Thu, 14 May 2009 10:33:44 +0100
- Subject: Re: fix thread instrumentation parameters
- References: <950a36fb0905130757x55b31052vaaffc202bc748f62@mail.gmail.com>
Hi Pieter-Jan
Pieter-Jan Busschaert wrote:
> While looking through instrumentation data, we found a bug in the data
> passed as arguments for THREAD_WAKE, THREAD_SUSPEND and THREAD_RESUME.
>
> In revision 1.10 of sched.hxx, SMP support was added, which changed
> current_thread from a simple pointer to an array-of-pointers. A
> convenience function get_current_thread() was added. The below
> instances of instrumentation code were not adapted, which makes them
> always pass the address of the array instead of a real thread pointer.
Yes, this is clearly a bug and the fix is trivial. Thank you for
bringing this to our attention.
John Dallaway