This is the mail archive of the ecos-patches@sourceware.org mailing list for the eCos project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Wed, May 12, 2010 at 15:04, Jonathan Larmour <jifl@jifvik.org> wrote: > > Heh, fair enough. > > Would you mind updating it with these minor changes: update the copyright dates, add eCos copyright headers to the two new files, and if you don't mind while you're there, enclose the whole block of prototypes in bsdstring.h in: > #ifndef __STRICT_ANSI__ I've attached a new version of my patch. There's a a new "requires" clause added to the CDL because I was concerned about someone enabling both CYGFUN_LIBC_STRING_BSD_FUNCS and strict ANSI mode and then start wondering why the BSD string function prototypes went silently missing. There are other GCC options that also imply __STRICT_ANSI__ though, e.g. "-std=c89", so maybe those should be added to the condition, for consistency. As for copyright, I really dislike adding pointless restrictions to code that's virtually unchanged, but IANAL of course, so it's a separate patch (hoping it won't get applied). Regards, -- Daniel Néri <daniel.neri@sigicom.com> Sigicom AB, Stockholm, Sweden
Attachment:
strlxxx.patch
Description: Binary data
Attachment:
strlxxx-copyright.patch
Description: Binary data
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |