This is the mail archive of the ecos-patches@sourceware.org mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PHY update


Hi Sachin, Chrristophe and Edgar

Sachin Sushil Chaddha wrote:

> I have received my Copyright Assignment form, which is attached for your
> reference.

That's great. Thank you.

> Christophe Coutand wrote:
> 
>> Attached are some new PHY support to HAL. Vitesse VSC8244 is part of a
>> port to Freescale 8572 evaluation board. Rest of the HAL for this
>> processor will follow.
>>
>> Let me know if the patch is correctly generated. IP101A is submitted on
>> behalf of Edgar Grimberg @ Zylin.com and VSC864 is submitted on behalf
>> of Sachin Sushil Chaddha @ stmi.com

Is there a reason why you have placed the PHY register definitions into
an external header file? Might they be required by other eCos packages?
If there _is_ a good reason, then we should add the standard copyright
banner to these header files and adhere to eCos file naming conventions.
Otherwise, I would suggest placing these definitions in the relevant .c
source files directly similar to the support for other PHY parts
(INLXT972.c and KSZ8041.c for example).

John Dallaway
eCos maintainer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]