This is the mail archive of the
ecos-patches@sourceware.org
mailing list for the eCos project.
Re: PHY update
- From: John Dallaway <john at dallaway dot org dot uk>
- To: Sachin Sushil Chaddha <schaddha at stmi dot com>, Christophe Coutand <ccoutand at stmi dot com>, Edgar Grimberg <edgar dot grimberg at zylin dot com>
- Cc: ecos-patches at ecos dot sourceware dot org, chadhas at ymail dot com
- Date: Tue, 08 Jun 2010 12:02:14 +0100
- Subject: Re: PHY update
- References: <D6050C555CC56940A7AF32652283027602C8B980@mail2.STMIRV01.COM> <4BEA8135.6040402@dallaway.org.uk> <D6050C555CC56940A7AF32652283027601116BF4@mail2.STMIRV01.COM>
Hi Sachin, Chrristophe and Edgar
Sachin Sushil Chaddha wrote:
> I have received my Copyright Assignment form, which is attached for your
> reference.
That's great. Thank you.
> Christophe Coutand wrote:
>
>> Attached are some new PHY support to HAL. Vitesse VSC8244 is part of a
>> port to Freescale 8572 evaluation board. Rest of the HAL for this
>> processor will follow.
>>
>> Let me know if the patch is correctly generated. IP101A is submitted on
>> behalf of Edgar Grimberg @ Zylin.com and VSC864 is submitted on behalf
>> of Sachin Sushil Chaddha @ stmi.com
Is there a reason why you have placed the PHY register definitions into
an external header file? Might they be required by other eCos packages?
If there _is_ a good reason, then we should add the standard copyright
banner to these header files and adhere to eCos file naming conventions.
Otherwise, I would suggest placing these definitions in the relevant .c
source files directly similar to the support for other PHY parts
(INLXT972.c and KSZ8041.c for example).
John Dallaway
eCos maintainer