This is the mail archive of the
ecos-patches@sourceware.org
mailing list for the eCos project.
Re: lwip_tcpip multi-line comment warning
On 02.01.2011 18:17, Sergei Gavrikov wrote:
> On Sun, 2 Jan 2011, Ilija Kocho wrote:
>
>> When lwip_tcpip is included and sequential option selected, the
>> following warning appears:
>>
>> packages/net/lwip_tcpip/current/src/ecos/sequential.c:118:8: warning:
>> multi-line comment
>>
>> The attached patch removes it.
>>
>> Ilija
> Hi Ilija,
>
> Could you, please, apply the same fix for src/ecos/simple.c:190 too? And
> add ChangeLog entry, please.
>
> Thanks,
> Sergei
>
Here it is, integral: simple.c, sequential.c and ChangeLog.
Ilija
Index: net/lwip_tcpip/current/ChangeLog
===================================================================
RCS file: /cvs/ecos/ecos-opt/net/net/lwip_tcpip/current/ChangeLog,v
retrieving revision 1.13
diff -u -5 -r1.13 ChangeLog
--- net/lwip_tcpip/current/ChangeLog 2 Aug 2010 07:35:10 -0000 1.13
+++ net/lwip_tcpip/current/ChangeLog 2 Jan 2011 19:55:49 -0000
@@ -1,5 +1,10 @@
+2011-01-02 Ilija Kocho <ilijak@siva.com.mk>
+
+ * src/ecos/sequential.c, src/ecos/simple.c: Fixed miltiple-line
+ comment warnings.
+
2010-08-02 John Dallaway <john@dallaway.org.uk>
* include/network.h: Match braces when including from C++ code.
Issue reported by Will Wagner.
Index: net/lwip_tcpip/current/src/ecos/sequential.c
===================================================================
RCS file: /cvs/ecos/ecos-opt/net/net/lwip_tcpip/current/src/ecos/sequential.c,v
retrieving revision 1.1
diff -u -5 -r1.1 sequential.c
--- net/lwip_tcpip/current/src/ecos/sequential.c 26 Jan 2010 11:27:49 -0000 1.1
+++ net/lwip_tcpip/current/src/ecos/sequential.c 2 Jan 2011 19:55:49 -0000
@@ -113,12 +113,12 @@
set_ip_addr(struct ip_addr *addr, u8_t a, u8_t b, u8_t c, u8_t d)
{
IP4_ADDR(addr, a, b, c, d);
}
-#endif // (LWIP_HAVE_LOOPIF && defined(CYGIMP_LWIP_LOOPIF_INSTANCE)) || \
- (LWIP_HAVE_SLIPIF && defined(CYGIMP_LWIP_SLIPIF_INSTANCE))
+#endif // (LWIP_HAVE_LOOPIF && defined(CYGIMP_LWIP_LOOPIF_INSTANCE)) ||
+ // (LWIP_HAVE_SLIPIF && defined(CYGIMP_LWIP_SLIPIF_INSTANCE))
#ifdef CYGFUN_LWIP_SHOW_NETIF_CONFIG
static void
show_netif_config(struct netif *netif)
Index: net/lwip_tcpip/current/src/ecos/simple.c
===================================================================
RCS file: /cvs/ecos/ecos-opt/net/net/lwip_tcpip/current/src/ecos/simple.c,v
retrieving revision 1.1
diff -u -5 -r1.1 simple.c
--- net/lwip_tcpip/current/src/ecos/simple.c 26 Jan 2010 11:27:49 -0000 1.1
+++ net/lwip_tcpip/current/src/ecos/simple.c 2 Jan 2011 19:55:49 -0000
@@ -185,12 +185,12 @@
}
return ERR_OK;
}
-#endif // (LWIP_HAVE_LOOPIF && defined(CYGIMP_LWIP_LOOPIF_INSTANCE)) || \
- (LWIP_HAVE_SLIPIF && defined(CYGIMP_LWIP_SLIPIF_INSTANCE))
+#endif // (LWIP_HAVE_LOOPIF && defined(CYGIMP_LWIP_LOOPIF_INSTANCE)) ||
+ // (LWIP_HAVE_SLIPIF && defined(CYGIMP_LWIP_SLIPIF_INSTANCE))
#ifdef CYGFUN_LWIP_SHOW_NETIF_CONFIG
static void
show_netif_config(struct netif *netif)