This is the mail archive of the
ecos-patches@sourceware.org
mailing list for the eCos project.
[Bug 1001291] New HAL for Cortex-M3 Smartfusion device
- From: bugzilla-daemon at bugs dot ecos dot sourceware dot org
- To: ecos-patches at ecos dot sourceware dot org
- Date: Mon, 13 Feb 2012 01:38:48 +0000
- Subject: [Bug 1001291] New HAL for Cortex-M3 Smartfusion device
- Auto-submitted: auto-generated
- References: <bug-1001291-104@http.bugs.ecos.sourceware.org/>
Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001291
--- Comment #48 from Jonathan Larmour <jifl@ecoscentric.com> 2012-02-13 01:38:37 GMT ---
(In reply to comment #46)
> In my proposal (1001449), I suggested to have a platform specific include in
> the test case C file that provides the configuration of the platform flash:
>
> #include CYGDAT_DEVS_FLASH_SPI_AT25DFXXX_PLF_CDL
>
> And CYGDAT_DEVS_FLASH_SPI_AT25DFXXX_PLF_CDL is defined in the platform CDL as
> done other places:
>
> define_proc {
> puts $::cdl_system_header "#define
> CYGDAT_DEVS_FLASH_SPI_AT25DFXXX_PLF_CDL
> <pkgconf/devs_flash_cortexm_a2f200_eval.h>"
> }
>
> What do you think?
Just a little thing but the naming of options like that should be something
like CYGDAT_DEVS_FLASH_SPI_AT25DFXXX_PLF_H, not _CDL. Using _CDL might mislead
some into thinking it has actual CDL in it, which obviously it doesn't.
Jifl
--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.