src/gdb ChangeLog corefile.c

[palves at sourceware dot org]

CVSROOT:	/cvs/src
Module name:	src
Changes by:	palves@sourceware.org	2013-03-07 23:36:01

Modified files:
	gdb            : ChangeLog corefile.c 

Log message:
	corefile.c: fix -Wpointer-sign
	
	$ make WERROR_CFLAGS="-Wpointer-sign -Werror" corefile.o -k 2>&1 1>/dev/null
	../../src/gdb/corefile.c: In function â??read_memory_stringâ??:
	../../src/gdb/corefile.c:334:7: error: pointer targets in passing argument 2 of â??read_memoryâ?? differ in signedness [-Werror=pointer-sign]
	../../src/gdb/corefile.c:217:1: note: expected â??gdb_byte *â?? but argument is of type â??char *â??
	
	Functions that take or return ascii-ish string arguments usually use
	char* for parameters/return.  That means that at points we call into
	target methods that work with binary blobs, we need casts to
	gdb_byte*.
	
	gdb/
	2013-03-07  Pedro Alves  <palves@redhat.com>
	
	* corefile.c (read_memory_string): Cast pointer to gdb_byte* in
	call.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.15224&r2=1.15225
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/corefile.c.diff?cvsroot=src&r1=1.71&r2=1.72