This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

src/gdb/gdbserver ChangeLog server.c


CVSROOT:	/cvs/src
Module name:	src
Changes by:	palves@sourceware.org	2013-05-24 11:28:06

Modified files:
	gdb/gdbserver  : ChangeLog server.c 

Log message:
	[gdbserver] Don't assume vCont;r ADDR1,ADDR2 comes with a ptid attached.
	
	This bit:
	
	+	  p1 = strchr (p, ':');
	+	  decode_address (&resume_info[i].step_range_end, p, p1 - p);
	
	should not expect the ':' to be there.  An action without a ptid is
	valid:
	
	"If an action is specified with no thread-id, then it is applied to any
	threads that don't have a specific action specified"
	
	This is handled further below:
	
	if (p[0] == 0)
	{
	resume_info[i].thread = minus_one_ptid;
	default_action = resume_info[i];
	
	/* Note: we don't increment i here, we'll overwrite this entry
	the next time through.  */
	}
	else if (p[0] == ':')
	
	A stub that doesn't support and report to gdb thread ids at all (like
	metal metal targets) only will always only see a single default action
	with no ptid.
	
	Use unpack_varlen_hex instead of decode_address.  The former doesn't
	need to be told where the hex number ends, and it actually returns
	that info instead, which we can use for validation.
	
	Tested on x86_64 Fedora 17.
	
	gdb/gdbserver/
	2013-05-24  Pedro Alves  <palves@redhat.com>
	
	* server.c (handle_v_cont) <vCont;r>: Use unpack_varlen_hex
	instead of strchr/decode_address.  Error if the range isn't split
	with a ','.  Don't assume there's be a ':' in the action.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/gdbserver/ChangeLog.diff?cvsroot=src&r1=1.717&r2=1.718
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/gdbserver/server.c.diff?cvsroot=src&r1=1.190&r2=1.191


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]