This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
gdb and binutils branch master updated. 05adc73e8266faab5abd485237cb59bb69a4f936
- From: palves at sourceware dot org
- To: gdb-cvs at sourceware dot org
- Date: 19 Mar 2014 15:57:37 -0000
- Subject: gdb and binutils branch master updated. 05adc73e8266faab5abd485237cb59bb69a4f936
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gdb and binutils".
The branch, master has been updated
via 05adc73e8266faab5abd485237cb59bb69a4f936 (commit)
via 6048b9501dec2a621a336bffdc6675646437a000 (commit)
via 8bcfb00a77f64a4496de90355f8c46b0da643e84 (commit)
via 884e37dceb64daa1c6d33f007fb294e809c47847 (commit)
via 148e57e2327e27e3d8bb6040138ea0843cf55e33 (commit)
via f48088c7de251319d9f874d07317d867e0cf66cb (commit)
via e2f6c966284e2f204779e9c7becf260bd4fe5117 (commit)
via c30568d4d17d1a1efa62d2f36651fd0228b0b8e5 (commit)
from 6caf711179d96da75860b79434bc792c92c0fa4c (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=05adc73e8266faab5abd485237cb59bb69a4f936
commit 05adc73e8266faab5abd485237cb59bb69a4f936
Author: Pedro Alves <palves@redhat.com>
Date: Wed Mar 19 13:05:43 2014 +0000
gdb.base/async.exp: Enable it.
There's no reason not to enable this test anymore.
Even if the current output isn't ideal (we mess up the prompt), it's what
we have today. We can adjust the test if the output improves.
gdb/testsuite/
2014-03-19 Pedro Alves <palves@redhat.com>
* gdb.base/async.exp: Remove early return.
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=6048b9501dec2a621a336bffdc6675646437a000
commit 6048b9501dec2a621a336bffdc6675646437a000
Author: Pedro Alves <palves@redhat.com>
Date: Wed Mar 19 15:22:45 2014 +0000
gdb.base/async.exp: Make test messages unique.
$ cat gdb.sum| grep PASS| sort | uniq -c |sort -n
1 PASS: gdb.base/async.exp: finish&
1 PASS: gdb.base/async.exp: jump&
1 PASS: gdb.base/async.exp: next&
1 PASS: gdb.base/async.exp: nexti&
1 PASS: gdb.base/async.exp: set exec-done-display off
1 PASS: gdb.base/async.exp: set exec-done-display on
1 PASS: gdb.base/async.exp: set target-async on
1 PASS: gdb.base/async.exp: stepi&
1 PASS: gdb.base/async.exp: until&
2 PASS: gdb.base/async.exp: step&
gdb/testsuite/
2014-03-19 Pedro Alves <palves@redhat.com>
* gdb.base/async.exp (step& tests): Pass explicit test messages.
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8bcfb00a77f64a4496de90355f8c46b0da643e84
commit 8bcfb00a77f64a4496de90355f8c46b0da643e84
Author: Pedro Alves <palves@redhat.com>
Date: Wed Mar 19 15:22:45 2014 +0000
gdb.base/async.exp: Fix races.
This test is currently racy:
PASS: gdb.base/async.exp: step&
stepi&
(gdb) 0x0000000000400547 14 x = 5; x = 5;
completed.
PASS: gdb.base/async.exp: stepi&
nexti&
(gdb) 15 y = 3;
completed.FAIL: gdb.base/async.exp: nexti&
The problem is here:
-re "^$command\r\n${before_prompt}${gdb_prompt}${after_prompt}completed\.\r\n" {
pass "$command"
}
-re "$gdb_prompt.*completed\.$" {
fail "$command"
}
Note how the fail pattern is a subset of the pass pattern. If the
expect buffer happens to end up with:
"^$command\r\n${before_prompt}${gdb_prompt}${after_prompt}completed\."
that is, the final "\r\n" has't reached the expect buffer yet, but
"completed." has, then the fail pattern matches...
gdb/testsuite/
2014-03-19 Pedro Alves <palves@redhat.com>
* gdb.base/async.exp (test_background): Expect \r\n after
"completed." in the fail pattern.
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=884e37dceb64daa1c6d33f007fb294e809c47847
commit 884e37dceb64daa1c6d33f007fb294e809c47847
Author: Pedro Alves <palves@redhat.com>
Date: Wed Mar 19 15:22:45 2014 +0000
gdb.base/async.exp: Factor out test pattern to a procedure.
All the tests here follow the same pattern (and they all have the same
problem, not fixed here yet). Add a new procedure, factoring out the
pattern to a simple place.
gdb/testsuite/
2014-03-19 Pedro Alves <palves@redhat.com>
* gdb.base/async.exp (test_background): New procedure.
Use it for all background execution command tests.
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=148e57e2327e27e3d8bb6040138ea0843cf55e33
commit 148e57e2327e27e3d8bb6040138ea0843cf55e33
Author: Pedro Alves <palves@redhat.com>
Date: Wed Mar 19 15:22:44 2014 +0000
gdb.base/async.exp: Use prepare_for_testing.
gdb/testsuite/
2014-03-19 Pedro Alves <palves@redhat.com>
* gdb.base/async.exp: Use prepare_for_testing.
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f48088c7de251319d9f874d07317d867e0cf66cb
commit f48088c7de251319d9f874d07317d867e0cf66cb
Author: Pedro Alves <palves@redhat.com>
Date: Wed Mar 19 15:22:44 2014 +0000
gdb.base/async.exp: Fix stepi& test.
Currently the test assumes that "stepi" over:
13 x = 5;
end up somewhere midline. But, (at least) on x86, that assignment
ends up compiled as just one movl instruction, so a stepi stops at the
next line already:
completed.
PASS: gdb.base/async.exp: step &
step&
(gdb) foo () at ../../../src/gdb/testsuite/gdb.base/async.c:13
13 x = 5;
completed.
PASS: gdb.base/async.exp: step &
stepi&
(gdb) 14 y = 3;
completed.
FAIL: gdb.base/async.exp: (timeout) stepi &
nexti&
(gdb) 16 return x + y;
completed.
FAIL: gdb.base/async.exp: (timeout) nexti &
finish&
Run till exit from #0 foo () at ../../../src/gdb/testsuite/gdb.base/async.c:16
This patch fixes it, by making sure there's more than one instruction
in that line.
gdb/testsuite/
2014-03-19 Pedro Alves <palves@redhat.com>
* gdb.base/async.c (foo): Make 'x' volatile. Write to it twice in
the same line.
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e2f6c966284e2f204779e9c7becf260bd4fe5117
commit e2f6c966284e2f204779e9c7becf260bd4fe5117
Author: Pedro Alves <palves@redhat.com>
Date: Wed Mar 19 15:22:44 2014 +0000
gdb.base/async.exp: Don't hardcode line numbers.
gdb/testsuite/
2014-03-19 Pedro Alves <palves@redhat.com>
* gdb.base/async.c (main): Add "jump here" and "until here" line
marker comments.
* gdb.base/async.exp (jump_here): New global.
(jump& test): Use it.
(until_here): New global.
(until& test): Use it.
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c30568d4d17d1a1efa62d2f36651fd0228b0b8e5
commit c30568d4d17d1a1efa62d2f36651fd0228b0b8e5
Author: Pedro Alves <palves@redhat.com>
Date: Wed Mar 19 15:22:44 2014 +0000
gdb.base/async.exp: Leave gdb_protocol alone.
Many eons ago, async was only implemented in the remote target, and
you'd activate it by doing "target async" rather than "target remote".
That's long gone now, replaced by "set target-async on".
gdb/testsuite/
2014-03-19 Pedro Alves <palves@redhat.com>
* gdb.base/async.exp: Don't frob gdb_protocol.
-----------------------------------------------------------------------
Summary of changes:
gdb/testsuite/ChangeLog | 40 ++++++++++++
gdb/testsuite/gdb.base/async.c | 9 ++-
gdb/testsuite/gdb.base/async.exp | 132 +++++++++++++-------------------------
3 files changed, 90 insertions(+), 91 deletions(-)
hooks/post-receive
--
gdb and binutils