This is the mail archive of the gdb-patches@sourceware.cygnus.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: (patch) hpjyg15: hppah-nat.c & related


Jimmy Guo wrote:
> 
> This patch updates hppah-nat.c and related files target.[ch] and
> infrun.c.  See ChangeLog below.
> 
> - Jimmy Guo, guo@cup.hp.com
> 
> ChangeLog
> 
> 1999-11-08      Jimmy Guo       <guo@cup.hp.com>
> 
>         * hppah-nat.c (child_xfer_memory): when reading, also try the
>           other way.
>           (require_notification_of_events): start by ignoring all
>           signals and then adding back in ones we're interested in.
>           (child_has_execd): cache pathname info, used for the 2nd exec
>           event reported by ptrace.
>           (child_pid_to_exec_file): make sure ptrace request for
>           pathname is made after an exec.
> 
>         * target.c (target_signal_exists): New function.  Given a GDB
>           target signal enum, return 1 if it's available on the host.
> 
>         * target.h (target_signal_exists): Declare.

I'd prefer the name (target_signal_p()) (Well actually I don't prefer
that name but its more consistent with the general naming convetion :-).

I'll check in a change to target.[ch] that adds the target_singal_p(). 
Hmm, I might do it slightly differently - were getting too many separate
places where there is code like:

	#if SIG...
	   case TARGET_SIGNAL...
	#endif

With that in, can the hppa-nat.c be re-submitted?  BTW, you might also
split it, I think it contains two changes - the code that uses this new
function and something else.

enjoy,
	Andrew

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]