Re: RFA: utils.c change

[David Taylor <taylor at cygnus dot com>]

    Date: Wed, 24 Nov 1999 15:51:17 -0700
    From: Kevin Buettner <kevinb@cygnus.com>
[...]
    Please let me know if it's okay to check in the change below...

	    * utils.c (verror): Don't traverse va_list argument twice.  Also,
	    removed extraneous va_end() call.

Approved.

    Index: utils.c
    ===================================================================
    RCS file: /cvs/cvsfiles/devo/gdb/utils.c,v
    retrieving revision 1.225
    diff -u -p -r1.225 utils.c
    --- utils.c     1999/11/16 00:03:36     1.225
    +++ utils.c     1999/11/24 21:58:25
    @@ -525,17 +525,28 @@ verror ()
     NORETURN void
     verror (const char *string, va_list args)
     {
    +  char *err_string;
    +  struct cleanup *err_string_cleanup;
       /* FIXME: cagney/1999-11-10: All error calls should come here.
	  Unfortunatly some code uses the sequence: error_begin(); print
	  error message; return_to_top_level.  That code should be
	  flushed. */
       error_begin ();
    -  vfprintf_filtered (gdb_stderr, string, args);
    -  fprintf_filtered (gdb_stderr, "\n");
    -  /* Save it as the last error as well (no newline) */
    +  /* NOTE: It's tempting to just do the following...
    +       vfprintf_filtered (gdb_stderr, string, args);
    +     and then follow with a similar looking statement to cause the message
    +     to also go to gdb_lasterr.  But if we do this, we'll be traversing the
    +     va_list twice which works on some platforms and fails miserably on
    +     others. */
    +  /* Save it as the last error */
       gdb_file_rewind (gdb_lasterr);
       vfprintf_filtered (gdb_lasterr, string, args);
    -  va_end (args);
    +  /* Retrieve the last error and print it to gdb_stderr */
    +  err_string = error_last_message ();
    +  err_string_cleanup = make_cleanup (free, err_string);
    +  fputs_filtered (err_string, gdb_stderr);
    +  fprintf_filtered (gdb_stderr, "\n");
    +  do_cleanups (err_string_cleanup);
       return_to_top_level (RETURN_ERROR);
     }