This is the mail archive of the gdb-patches@sourceware.cygnus.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [RFC] Move/Rename include/wait.h ("wait.h")



   From: jtc@redback.com (J.T. Conklin)
   Date: 09 Dec 1999 10:53:48 -0800

   >>>>> "Andrew" == Andrew Cagney <ac131313@cygnus.com> writes:
   Andrew> I'd like to put forward the proposal that the file
   Andrew> ``include/wait.h'' be either:
   Andrew> 	o	renamed to include/gnu-wait.h (?)
   Andrew> 	o	moved to gdb/gdb-wait.h

   If it's not used by other programs, I'd recommend that it be moved to
   gdb_wait.h (with an underscore, not a dash).  I created gdb_string.h
   and gdb_stat.h long ago for the same sort of reasons.

I agree, this sounds like the right idea.

   We might also want to consider creating a gdb_fcntl.h header to wrap
   fcntl.h.  It would would define O_BINARY to 0 on hosts that don't
   distinguish between text and binary files; instead of having that
   definition scattered throughout various *.c files.

This would be good too, we have picked up a number of redundant
definitions...  Might be a good idea to consider doing the include
of fcntl.h in defs.h, it's mentioned explicitly in nearly half the
source files already, and the compiletime overhead of including it
always would be pretty minor.

								Stan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]